Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-361 fix subscription message announcement #1952

Merged
merged 2 commits into from
Jan 19, 2021
Merged

fix(storefront): BCTHEME-361 fix subscription message announcement #1952

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3b38eb
fix(storefront): BCTHEME-361 fix subscription message announcement
bc-alexsaiannyi Jan 15, 2021
85b99cf
Merge branch 'master' into bctheme-361
bc-alexsaiannyi Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fixed announcement of subscription message. [#1952](https://github.com/bigcommerce/cornerstone/pull/1952)
- Carousel buttons do not receive focus. [#1937](https://github.com/bigcommerce/cornerstone/pull/1937)
- Empty cart message not read by screen reader. [#1935](https://github.com/bigcommerce/cornerstone/pull/1935)
- No tooltips provided for carousel buttons. [#1934](https://github.com/bigcommerce/cornerstone/pull/1934)
Expand Down
7 changes: 6 additions & 1 deletion templates/pages/subscribed.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<section class="page">
<div class="page-content page-content--centered">
<h1 class="page-heading" tabindex="0">
<h1 class="page-heading" tabindex="0" role="status" aria-live="assertive">
{{#if subscription.error}}
{{lang 'newsletter.subscribed_heading_error'}}
{{else}}
Expand All @@ -19,5 +19,10 @@ <h1 class="page-heading" tabindex="0">
</div>
</section>

<script>
const subscriptionStatusElement = document.querySelector('.page-content > .page-heading');
if (subscriptionStatusElement) subscriptionStatusElement.focus();
</script>

{{/partial}}
{{> layout/base}}