Signature verification #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add editorconfig file
| if (time_strcmp($sig, $expected_sig)) { | ||
| error_log('Bad Signed JSON signature!'); | ||
| $expectedSignature = hash_hmac('sha256', $jsonStr, clientSecret(), $raw = false); | ||
| if (!hash_equals($expectedSignature, $signature)) { |
There was a problem hiding this comment.
hash_equals only exists in php 5.6+
We should note that in the README or pull in a compatibility lib (t-richards/hash_equals looks good)
|
Thanks for this. The example ruby/php/python apps and server side implementation in our oauth server all had different authors and very different level of scrutinization/code review :( |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a security flaw in the
parse_signed_requestfunction. I'm not the only one to encounter issues with this code - see http://stackoverflow.com/questions/24463410/bigcommerce-fail-to-verify-the-load-callbacks