New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gene and related models and parsing code #1129

Closed
heuermh opened this Issue Aug 25, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@heuermh
Member

heuermh commented Aug 25, 2016

In addition to the changes proposed in #1118, remove Gene and related models and remove the parsing code in FeatureParser.

This could be added to the pull request linked above or split out into a separate pull request.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Sep 6, 2016

Member

Fixed by #1118

Member

heuermh commented Sep 6, 2016

Fixed by #1118

@heuermh heuermh closed this Sep 6, 2016

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Sep 8, 2016

Member

@fnothaft after merging #1118 I don't see the changes from the commit in fnothaft#10.

E.g. GeneRdd.scala, Features.reassignParentIds, etc. are still there.

Member

heuermh commented Sep 8, 2016

@fnothaft after merging #1118 I don't see the changes from the commit in fnothaft#10.

E.g. GeneRdd.scala, Features.reassignParentIds, etc. are still there.

@heuermh heuermh reopened this Sep 8, 2016

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 8, 2016

Member

Oh no! I goofed there with a force push and accidentally blew fnothaft/#10 away after merging... Do you want to reopen your PR against here? If not, I can do it. Sorry about the goof!

Member

fnothaft commented Sep 8, 2016

Oh no! I goofed there with a force push and accidentally blew fnothaft/#10 away after merging... Do you want to reopen your PR against here? If not, I can do it. Sorry about the goof!

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Sep 8, 2016

Member

Yeah I think I can redo it against master.

Member

heuermh commented Sep 8, 2016

Yeah I think I can redo it against master.

@heuermh heuermh changed the title from Remove loadGenes and PrintGenes command to Remove Gene and related models and parsing code Sep 8, 2016

@heuermh heuermh modified the milestone: 0.20.0 Sep 8, 2016

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 9, 2016

Member

Resolved by #1153, which was merged as 9eb0d60.

Member

fnothaft commented Sep 9, 2016

Resolved by #1153, which was merged as 9eb0d60.

@fnothaft fnothaft closed this Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment