Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Gene and related models and parsing code #1129

Closed
heuermh opened this issue Aug 25, 2016 · 5 comments
Closed

Remove Gene and related models and parsing code #1129

heuermh opened this issue Aug 25, 2016 · 5 comments
Milestone
0.20.0

Comments

@heuermh
Copy link
Member

heuermh commented Aug 25, 2016

In addition to the changes proposed in #1118, remove Gene and related models and remove the parsing code in FeatureParser.

This could be added to the pull request linked above or split out into a separate pull request.
@heuermh heuermh mentioned this issue Aug 31, 2016
Merged
@heuermh
Copy link
Member Author

heuermh commented Sep 6, 2016

Fixed by #1118

@heuermh heuermh closed this as completed Sep 6, 2016
@heuermh
Copy link
Member Author

heuermh commented Sep 8, 2016 •
edited
Loading

@fnothaft after merging #1118 I don't see the changes from the commit in fnothaft#10.

E.g. GeneRdd.scala, Features.reassignParentIds, etc. are still there.

@heuermh heuermh reopened this Sep 8, 2016
@fnothaft
Copy link
Member

fnothaft commented Sep 8, 2016

Oh no! I goofed there with a force push and accidentally blew fnothaft/#10 away after merging... Do you want to reopen your PR against here? If not, I can do it. Sorry about the goof!

@heuermh
Copy link
Member Author

heuermh commented Sep 8, 2016

Yeah I think I can redo it against master.

This was referenced Sep 8, 2016
Closed
Closed
@heuermh heuermh changed the title Remove loadGenes and PrintGenes command Remove Gene and related models and parsing code Sep 8, 2016
@heuermh heuermh modified the milestone: 0.20.0 Sep 8, 2016
@fnothaft
Copy link
Member

fnothaft commented Sep 9, 2016

Resolved by #1153, which was merged as 9eb0d60.

@fnothaft fnothaft closed this as completed Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
2 participants
@heuermh @fnothaft