Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map IntervalList format column four to feature name or attributes? #1152

Closed
heuermh opened this issue Sep 7, 2016 · 2 comments
Closed

Map IntervalList format column four to feature name or attributes? #1152

heuermh opened this issue Sep 7, 2016 · 2 comments
Milestone
0.20.0

Comments

@heuermh
Copy link
Member

heuermh commented Sep 7, 2016

We are not sure if the name column should be mapped to Feature.name or to Feature.attributes.

Note discussion here
https://github.com/bigdatagenomics/adam/pull/1104/files#r77733324
https://github.com/bigdatagenomics/adam/pull/1104/files#r74367312

Ping @ryan-williams to comment.
@heuermh heuermh mentioned this issue Sep 7, 2016
Merged
@tdanford
Copy link
Contributor

tdanford commented Sep 7, 2016

I vote: map it to Feature.name. People can parse it out into attributes manually if they're abusing the name field to store key-value pairs.

@heuermh heuermh modified the milestone: 0.20.0 Sep 7, 2016
This was referenced Sep 7, 2016
Closed
Closed
@fnothaft
Copy link
Member

Resolved by 53b8f48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
3 participants
@heuermh @tdanford @fnothaft