Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove, or add documentation to, FeatureHierarchy #709

Closed
ryan-williams opened this issue Jun 4, 2015 · 4 comments
Closed

Remove, or add documentation to, FeatureHierarchy #709

ryan-williams opened this issue Jun 4, 2015 · 4 comments
Labels
question

Comments

@ryan-williams
Copy link
Member

I stumbled across this today; what is it, why is it here? It appears unused.

I'm open to variations on what I imagine it is supposed to do, but it seems like it might have been an idea that was abandoned, in which case I'll remove it. Can anyone provide context?
@fnothaft
Copy link
Member

fnothaft commented Jun 4, 2015

CC @tdanford @laserson

@laserson
Copy link
Contributor

laserson commented Jun 5, 2015

I think this is a remnant of an early "feature" proposal that would provide familiar interfaces for Feature objects that were similar to their sources. I don't think I've used it myself, and your reporting this issue is making me think it's not used anywhere in the codebase, so I'm fine with nixing it.

@fnothaft
Copy link
Member

fnothaft commented Jun 9, 2015

I would be +1 towards removing it.

@neurons neurons mentioned this issue Jul 3, 2015
Closed
@neurons neurons mentioned this issue Jul 15, 2015
Merged
@fnothaft
Copy link
Member

Closed by #728.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laserson @ryan-williams @fnothaft