Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding containsRefName to SequenceDictionary #47

Merged

Conversation

tdanford
Copy link
Contributor

(A little update, I'm separating this out and filing it as a separate pull request from a larger request which will follow from us here at GenomeBridge later this week.)

Added containsRefName to SequenceDictionary, allowing us to check whether a SequenceDictionary object contains a particular sequence.

SequenceDictionary recordNames keys should be Strings (they had been Avro Utf8 objects, which was messing up lookups into the map itself from Strings).

Added containsRefName to SequenceDictionary, allowing us to check whether a SequenceDictionary object contains a particular sequence.
SequenceDictionary recordNames keys should be Strings (they had been Avro Utf8 objects, which was messing up lookups into the map itself from Strings).
@tdanford
Copy link
Contributor Author

Not sure why the merge build didn't finish...?

@carlyeks
Copy link
Member

Looks like the build is stuck: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/29/console

@tdanford
Copy link
Contributor Author

@massie or @fnothaft -- are you guys able to help?

@AmplabJenkins
Copy link

One or more automated tests failed
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/29/

@fnothaft
Copy link
Member

Sorry for the slow reply—I just killed the build and am letting it rerun. If it hangs a second time, I'll look into this more deeply. I presume that the unit tests ran OK on your side?

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/30/

@fnothaft
Copy link
Member

Yep—looks like it was some small hiccup...

@tdanford
Copy link
Contributor Author

Yeah, it's only a small change (2-3 lines, plus a test) and all the tests finished fine on our side -- as it appears they did on yours too. Like I said, this is a small, separable thing which is preparatory to larger changes later.

fnothaft added a commit that referenced this pull request Jan 15, 2014
Adding containsRefName to SequenceDictionary
@fnothaft fnothaft merged commit e812479 into bigdatagenomics:master Jan 15, 2014
@fnothaft
Copy link
Member

Yeah—odd little hiccup! I think the PR builder may run on spot instances, so it is possible that the spot instance was revoked mid build? Don't quote me on that though.

Anywho! Thanks for the change! I've merged it, and am looking forward to seeing what comes next!

@tdanford tdanford deleted the tdanford/seq-dict-contains-ref branch January 15, 2014 18:12
@tdanford
Copy link
Contributor Author

Thanks, Frank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants