Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hadoop 2.2.0 support, upgrade to Spark 0.8.1 #53

Merged
merged 4 commits into from Jan 16, 2014

Conversation

jey
Copy link
Contributor

@jey jey commented Jan 15, 2014

This is a continuation of @arahuja's PR #39 with the following changes:

  1. Fixed the "No Filesystem found for scheme: ..." errors by merging the META-INF/services files when building the shaded assembly JAR.
  2. Modifies the POM so that the default hadoop.version setting of 2.2.0 produces a working build without having to additionally enable a Maven profile.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/35/

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/37/

@massie
Copy link
Member

massie commented Jan 16, 2014

Can you confirm that Hadoop 1.0.4 still works?

When I followed the instructions in the comment and tried to build for 1.0.4 I got the following error:

Cause: java.lang.ClassNotFoundException: scala.util.Try$

which is caused I believe from using Scala 2.9.2 instead of 2.9.3.

@arahuja
Copy link
Contributor

arahuja commented Jan 16, 2014

Matt that is the issue that was occurring under the main (no profile) build with my change. I looked into that and looks like that can be resolved by explicitly pulling in the correct scala version. The issue came up in the Spark project as well, see: mesos/spark#688

@jey
Copy link
Contributor Author

jey commented Jan 16, 2014

Good catch. I added an explicit dependency on scala-library and it then built against Hadoop 1.0.4. I'm now testing to see whether 2.2.0 still works as expected.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/38/

@jey
Copy link
Contributor Author

jey commented Jan 16, 2014

I guess Jenkins beat me to the punch.

massie added a commit that referenced this pull request Jan 16, 2014
Fix Hadoop 2.2.0 support, upgrade to Spark 0.8.1
@massie massie merged commit 20a1bbc into bigdatagenomics:master Jan 16, 2014
@massie
Copy link
Member

massie commented Jan 16, 2014

Thanks, Jey!

@jey jey deleted the hadoop22-fix branch February 4, 2014 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants