Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic show hide #73

Merged
merged 2 commits into from
Jan 30, 2017
Merged

Add basic show hide #73

merged 2 commits into from
Jan 30, 2017

Conversation

allanhortle
Copy link
Contributor

@allanhortle allanhortle commented Jan 30, 2017 •
edited
Loading

#22

Currently Using props.show as the main trigger. Open to better suggestions as defaultShow is a silly prop name.

  • ShowHide
  • ShowHideStateful
  • 100% coverage
  • Basic example

dancoates
dancoates approved these changes Jan 30, 2017
View reviewed changes
Copy link
Contributor

@dancoates dancoates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@allanhortle allanhortle merged commit cb6fcbe into master Jan 30, 2017
@allanhortle allanhortle deleted the feature/show-hide branch January 30, 2017 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dxinteractive dxinteractive dxinteractive approved these changes

@dancoates dancoates dancoates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allanhortle @dxinteractive @dancoates