New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Linked Timezones #144
Comments
A bug and a good suggestion. Will fix. Will consider. (Send from phone.) On Thursday, March 14, 2013, Adam Sanderson wrote:
|
Rather than store a link in the JavaScript zone information file, I instead create a full JavaScript zone information file. When someone is loading the entire database at once, this is going to be wasteful, but when someone is requesting timezones over the web as needed, this is going to be most efficient. Because I'm using one object to preserve the state of the `tz` function, I've counted on the fact that the active set of normalized timezone names all have a slash in them, while all of the zone rules do not. When adding timezones links, the created a collision when the legacy timezone name `Cuba` collided with the DST rules named `Cuba`. The obvious solution to this is to store the names with a `z:` or `r:` prefix in the enclosed timezone object. The `US/Pacific` timezone mentioned in #144 is now visible.
Are you blocking on a solution? I can do a release now with this temporary fix. I'll do a more thorough implementation of links over the weekend. |
Thanks for the quick turnaround! Don't worry about a release just for me, I think I actually need something more low level. I'm doing thousands of By the way, I really liked your On Fri, Mar 15, 2013 at 1:57 PM, Alan Gutierrez notifications@github.comwrote:
|
Thank you for the feedback on It sounds like you're invoking What date string are you using to get local time? I can see if any of the optimizations are faster for that specific case. |
My use case would looks roughly like this:
some code to pin it to 00:00:00 for the date
In On Fri, Mar 15, 2013 at 4:12 PM, Alan Gutierrez notifications@github.comwrote:
|
I may be missing something, but is it possible to reference linked timezones? For instance, I have users with the
US/Pacific
timezone, which I believe is linked toAmerica/Los_Angeles
. If I try to operate on times withUS/Pacific
,timezone
seems to silently assume UTC:Any suggestions? Also, is there any way to find out if a timezone was not found, a strict mode perhaps?
The text was updated successfully, but these errors were encountered: