Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure component attributes can be set on construction #126

Open
esheldon opened this issue Mar 29, 2017 · 4 comments
Open

make sure component attributes can be set on construction #126

esheldon opened this issue Mar 29, 2017 · 4 comments

Comments

@esheldon
Copy link
Collaborator

An example is label which can't be set on construction. This does not produce a visible PlotKey because label is not set

key=PlotKey(0.1, 0.9, halign='left')
plt=FramedPlot(key=key)
plt.add(Points([3,4], [5,6], label='stuff'))
@beckermr
Copy link
Collaborator

This will be easier if we address #82.

@beckermr
Copy link
Collaborator

Also #19

@esheldon
Copy link
Collaborator Author

looks like only style is being set from the keywords on construction

So we need to special case label (and maybe others) which is not a style

@esheldon esheldon mentioned this issue Mar 29, 2017
Merged
esheldon added a commit that referenced this issue Mar 29, 2017
@esheldon
Merge pull request #128 from biggles-plot/#126
58cdaaf 
pass on constructor keywords to the base class
@esheldon
Copy link
Collaborator Author

The above PR put the framework in place for this, but so far I only found label for attributes to be set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@esheldon @beckermr