Initial request migration #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request is deprecated so we need to migrate to an alternate library.See: request/request#3142
mattandrews
approved these changes
Feb 13, 2020
| qs: params | ||
| }); | ||
| query(searchParams) { | ||
| return queryPastGrants('', { searchParams: searchParams }).json(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2949 for the context on this.
Begins migrating away from
requestandrequest-promise-nativeto an alternate library.gotlooks like the best candidate as they have a clear migration guide for the most common things and reasonable docs.Did a bit of a spike into migrating all instances of
request-promise-nativein another branch and most changes are straightforward. The one part that needs a bit more translation is file attachments as part of salesforce submissions.This pull request focuses solely on migrating the grants service. Of all the changes needed this was the most straightforward and most targeted so seems like a good enough place to start.