This repository has been archived by the owner on Jun 2, 2018. It is now read-only.
Swift 2.3 #159
Merged
Swift 2.3 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomstep
approved these changes
Sep 23, 2016
| let _ = try? fm.removeItemAtURL(storeURL.URLByAppendingPathComponent("-shm")) | ||
| let _ = try? fm.removeItemAtURL(storeURL.URLByAppendingPathComponent("-wal")) | ||
| if let indexURL = storeURL.URLByAppendingPathComponent("-shm") { | ||
| let _ = try? fm.removeItemAtURL(indexURL) |
There was a problem hiding this comment.
Can leave the let off of _ = try? ...
rcedwards
force-pushed
the
rcedwards/swift_2.3
branch
from
07b7d8e
to
f948483
Compare
…Description is available
This makes it easier to add different configuration params to each platform
rcedwards
force-pushed
the
rcedwards/swift_2.3
branch
from
8e2f5ab
to
5d2c1d8
Compare
This is a good starting point for Circle should we decide to go this route but since its not in use it will be clearer with the config commented out.
This is also not being used at the moment and is not needed
rcedwards
force-pushed
the
rcedwards/swift_2.3
branch
from
d6b32e4
to
62467ac
Compare
rcedwards
force-pushed
the
rcedwards/swift_2.3
branch
from
62467ac
to
2a49b34
Compare
zwaldowski
approved these changes
Oct 6, 2016
| @@ -53,5 +51,7 @@ DESC | |||
| s.source_files = "Sources" | |||
|
|
|||
| s.frameworks = "CoreData" | |||
| s.pod_target_xcconfig = { 'SWIFT_VERSION' => '2.3', | |||
| 'SWIFT_INCLUDE_PATHS': '$(PODS_ROOT)/Sources' } | |||
There was a problem hiding this comment.
SWIFT_INCLUDE_PATHS isn't needed, only was in Deferred.
| } | ||
| if let walFile = storeURL.URLByAppendingPathComponent("-wal") { | ||
| let _ = try? fm.removeItemAtURL(walFile) | ||
| } |
There was a problem hiding this comment.
It's 100% OK to ! the URLs you get back from URLByAppendingPathComponent. They were only made ? for arcane reasons.
This resolves the pod linting not targeting the correct deployment version of tvOS, iOS, macOS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Todo List
Summary of Changes
CoreDataStackandCoreDataModelableAddresses
#152