-
Notifications
You must be signed in to change notification settings - Fork 76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I did not run it locally though.
let _ = try? fm.removeItemAtURL(storeURL.URLByAppendingPathComponent("-shm")) | ||
let _ = try? fm.removeItemAtURL(storeURL.URLByAppendingPathComponent("-wal")) | ||
if let indexURL = storeURL.URLByAppendingPathComponent("-shm") { | ||
let _ = try? fm.removeItemAtURL(indexURL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can leave the let
off of _ = try? ...
07b7d8e
to
f948483
Compare
…Description is available
This makes it easier to add different configuration params to each platform
8e2f5ab
to
5d2c1d8
Compare
This is a good starting point for Circle should we decide to go this route but since its not in use it will be clearer with the config commented out.
This is also not being used at the moment and is not needed
d6b32e4
to
62467ac
Compare
62467ac
to
2a49b34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecation bits are fine. 👍 overall.
@@ -53,5 +51,7 @@ DESC | |||
s.source_files = "Sources" | |||
|
|||
s.frameworks = "CoreData" | |||
s.pod_target_xcconfig = { 'SWIFT_VERSION' => '2.3', | |||
'SWIFT_INCLUDE_PATHS': '$(PODS_ROOT)/Sources' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SWIFT_INCLUDE_PATHS
isn't needed, only was in Deferred.
} | ||
if let walFile = storeURL.URLByAppendingPathComponent("-wal") { | ||
let _ = try? fm.removeItemAtURL(walFile) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's 100% OK to !
the URLs you get back from URLByAppendingPathComponent
. They were only made ?
for arcane reasons.
This resolves the pod linting not targeting the correct deployment version of tvOS, iOS, macOS
Release Todo List
Summary of Changes
CoreDataStack
andCoreDataModelable
Addresses
#152