Add bias-shades #37
Merged
Add bias-shades #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarvanderwal
force-pushed
the
master
branch
from
623a862
to
d0d731b
Compare
Removed language subsets that have no prompts yet.
|
This PR depends on the French and English prompts to be added in promptsource. |
…p#143) * [feature] Add task constructor arg support to CLI * Add tests * Fix bad text separator arg test * Loosen CLI parsing `strip` and `split` constraints * Update CLI arg string task creation unit tests * Update `main.py` arg help for `--task_args` * Add `task_args` to results metadata * Add arg string parsing edge case tests * Add misc. symbol checks to test
Removed language subsets that have no prompts yet.
jon-tow
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
@oskarvanderwal Thanks for putting this together! I've added bias-shades to the task registry and did a little refactoring to match similar tasks.
I ran into one minor issue - for some reason, the Spanish convert_to_stereotype template does not appear to be working properly
text, _ = self.prompt_template.apply(doc)
ValueError: not enough values to unpack (expected 2, got 1)These errors almost always stem from the promptsource side. If you can confirm this, then we can go ahead and merge this.
|
@jon-tow, thanks for your work! I have asked the author of the Spanish prompts to review the problematic template. I'm pretty sure the problem is coming from the promptsource side, so those prompts should be checked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task implements the bias-shades dataset for French and English. I'll add the other languages, when the respective prompts are available.