Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New prompts for Shades FR/EN #742

Closed
wants to merge 7 commits into from

Conversation

aneveol
Copy link

@aneveol aneveol commented Apr 26, 2022

This is a test PR for the BigScience eval hackathon. The goals is to use these three new prompts for crowS-pairs to the following end:
1/ test process/pipeline (I think that works)
2/ get feedback on prompts format: are they acceptable?
3/ how will the metric "other" be defined? Here, we essentially need a count of answers, to convert into the proportion of "sentence A" answers.

(Our goal this week is to get the bias eval done on the revised/upgraded crowS-pairs_multilingual dataset).

@KhalidAlt
Copy link
Contributor

The template with id:493b3361-f28d-4489-87b3-b42ae90e5e3a does not have a target or output. You need to add the output as you did for the reset : ||| {{answer_choices[stereo_antistereo]}}

@aneveol
Copy link
Author

aneveol commented Apr 26, 2022

Thank you for the suggestion. I made the change. However, I am not sure I understand whether this is going to have the desired effect for the metric planned ("other").

@jzf2101 jzf2101 self-requested a review April 26, 2022 22:18
@jzf2101 jzf2101 self-assigned this Apr 26, 2022
@jzf2101 jzf2101 changed the base branch from main to eval-hackathon April 26, 2022 23:27
@oskarvanderwal
Copy link

@aneveol, answer_choices[stereo_antistereo] wouldn't work as the target, since stereo_antistereo is not an integer label of which choice is the most stereotypical answer, but a string indicating whether it is about a stereotypical choice or an anti-stereotypical choice. I think we should always suggest the sent_more (more stereotypical choice) as the target.

I have fixed this and also added your prompts to my PR.

…orkshop#778)

* accelerate `get_infos` by caching the `DataseInfoDict`s

* quality

* consistency
@jzf2101
Copy link
Collaborator

jzf2101 commented May 25, 2022

@oskarvanderwal we have merge conflicts that have to be resolved - also I don't see the dataset listed on promptsource. I think this PR needs to be cleaned up before merging. For some reason the PR did not build.

@oskarvanderwal
Copy link

oskarvanderwal commented May 25, 2022

@jzf2101 Sorry, I don't have access to this repository (yet). My PR for CrowS-Pairs can be found here. This PR is about the bias-shades dataset, but I agree we need to clean some things up.

@aneveol Maybe you could rename this PR to "Adding prompts for French and English bias-shades"? Then also

  • remove the CrowS-Pairs prompts,
  • add BigScienceEvalWG as user, and
  • make sure your repository is up-to-date with the original.
    I can help out with this if you add me as contributor to this repo :)

@aneveol aneveol changed the title 3 new prompts for crowS-pairs New prompts for Shades FR/EN May 26, 2022
@oskarvanderwal
Copy link

@jzf2101 I have cleaned this PR and fixed the prompt answer choices. Let me know if there is anything else required for this PR!

@jzf2101
Copy link
Collaborator

jzf2101 commented Jun 27, 2022

@oskarvanderwal there are merge conflicts, could you resolve?

VictorSanh and others added 3 commits July 3, 2022 18:48
* fix empty documents - multi_news

* fix test - unrecognized variable
* Added languages widget to UI.

* Style fixes.

* Added English tag to existing datasets.

* Add languages to viewer mode.

* Update language codes.

* Update CONTRIBUTING.md.

* Update screenshot.

* Add "Prompt" to UI to clarify languages tag usage.
@StellaAthena
Copy link

@jzf2101 Are there additional changes that need to be made to this PR or can it be merged?

@oskarvanderwal
Copy link

@jzf2101, I have created a new PR for adding French and English prompts without any blocking merge conflicts here: #837

This PR can be closed.

@jzf2101
Copy link
Collaborator

jzf2101 commented Nov 2, 2022

Closed for #837

@jzf2101 jzf2101 closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants