Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import petals.utils.peft only when needed to avoid unnecessary import of bitsandbytes #345

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Import petals.utils.peft only when needed to avoid unnecessary import of bitsandbytes #345

merged 2 commits into from
Jul 12, 2023

Conversation

borzunov
Copy link
Collaborator

The motivation is the same as in #180.

justheuristic
justheuristic approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely LGTM; I have a sneaking suspicion that we've probably imported peft elsewhere as well.

@borzunov borzunov merged commit 43acfe5 into main Jul 12, 2023
6 of 7 checks passed
@borzunov borzunov deleted the import-peft-when-necessary branch July 12, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justheuristic justheuristic justheuristic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@borzunov @justheuristic