Prefer longer servers for fine-tuning, exclude unreachable #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
commented
Aug 7, 2023
| @@ -50,7 +50,7 @@ class SequenceManagerConfig: | |||
| ban_timeout: float = 15 # when a remote peer fails to respond, prevent routing to that peer for this many seconds | |||
| active_adapter: Optional[str] = None # name of active LoRA adapter (usually, Hugging Face repo) | |||
|
|
|||
| max_pinged: int = 5 # max servers to ping from each sequence side, per update | |||
| max_pinged: int = 3 # max servers to ping from each sequence side, per update | |||
There was a problem hiding this comment.
3 servers for start, middle, and end of sequence per update. It's stored for 5 min, so we'll have info about up to 45 servers after a while.
borzunov
commented
Aug 7, 2023
| span_weights = np.array( | ||
| [span.length if client_server_rtts.get(span.peer_id) != np.inf else eps for span in candidate_spans], | ||
| dtype=np.float64, | ||
| ) |
There was a problem hiding this comment.
If not pinged yet, we'll have (None != np.inf) == False here
justheuristic
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We choose longer servers to minimize the number of hops but leave some randomization to distribute the load. We also exclude servers known to be unreachable.