-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove transformer block, implement as sequence size 1 #54
Conversation
TODO:
|
src/dht_utils.py
Outdated
) | ||
|
||
|
||
async def _get_sequence_blocks( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async def _get_sequence_blocks( | |
async def _get_remote_sequence( |
In the rest of file, private coroutines have the same name as public non-async functions. Let's stick to that in the new functions as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied as a separate commit
src/dht_utils.py
Outdated
return RemoteExpertWorker.run_coroutine(_unpack(infos, dht), return_future) | ||
p2p = RemoteExpertWorker.run_coroutine(dht.replicate_p2p()) | ||
modules = _create_remote_modules_from_infos(infos, p2p) | ||
async def _get_distinct_blocks( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async def _get_distinct_blocks( | |
async def _get_remote_module( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied as a separate commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this given that all my edits will be applied.
Co-authored-by: Alexander Borzunov <hxrussia@gmail.com>
Co-authored-by: Alexander Borzunov <hxrussia@gmail.com>
Co-authored-by: Alexander Borzunov <hxrussia@gmail.com>
[Applied all edits.] @GreenFatGuy i may have overstepped by doing so: if you wanna dispute something i can prepare a separate this a PR to rollback the changes that you would rather avoid.. |
Remove
RemoteTransformerBlock
as independent class and implement asRemoteSequential
size 1