remove transformer block, implement as sequence size 1 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
justheuristic
approved these changes
Aug 31, 2022
justheuristic
approved these changes
Aug 31, 2022
borzunov
requested changes
Sep 1, 2022
src/dht_utils.py
Outdated
| ) | ||
|
|
||
|
|
||
| async def _get_sequence_blocks( |
There was a problem hiding this comment.
Suggested change
| async def _get_sequence_blocks( | |
| async def _get_remote_sequence( |
In the rest of file, private coroutines have the same name as public non-async functions. Let's stick to that in the new functions as well.
There was a problem hiding this comment.
applied as a separate commit
src/dht_utils.py
Outdated
| return RemoteExpertWorker.run_coroutine(_unpack(infos, dht), return_future) | ||
| p2p = RemoteExpertWorker.run_coroutine(dht.replicate_p2p()) | ||
| modules = _create_remote_modules_from_infos(infos, p2p) | ||
| async def _get_distinct_blocks( |
There was a problem hiding this comment.
Suggested change
| async def _get_distinct_blocks( | |
| async def _get_remote_module( |
There was a problem hiding this comment.
applied as a separate commit
borzunov
approved these changes
Sep 1, 2022
Co-authored-by: Alexander Borzunov <hxrussia@gmail.com>
Co-authored-by: Alexander Borzunov <hxrussia@gmail.com>
Co-authored-by: Alexander Borzunov <hxrussia@gmail.com>
[Applied all edits.] @GreenFatGuy i may have overstepped by doing so: if you wanna dispute something i can prepare a separate this a PR to rollback the changes that you would rather avoid.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
RemoteTransformerBlockas independent class and implement asRemoteSequentialsize 1