test + test fixes

bigskysoftware · May 26, 2020 · d144742 · d144742
1 parent 1159d13
commit d144742
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 2 deletions.
diff --git a/src/htmx.js b/src/htmx.js
@@ -33,6 +33,11 @@ return (function () {
         }
 
         // resolve with both hx and data-hx prefixes
+        function hasAttribute(elt, qualifiedName) {
+            return elt.hasAttribute && (elt.hasAttribute(qualifiedName) ||
+                elt.hasAttribute("data-" + qualifiedName));
+        }
+
         function getAttributeValue(elt, qualifiedName) {
             return getRawAttribute(elt, qualifiedName) || getRawAttribute(elt, "data-" + qualifiedName);
         }
@@ -825,7 +830,7 @@ return (function () {
         function processVerbs(elt, nodeData, triggerSpecs) {
             var explicitAction = false;
             forEach(VERBS, function (verb) {
-                if (elt.hasAttribute('hx-' + verb)) {
+                if (hasAttribute(elt,'hx-' + verb)) {
                     var path = getAttributeValue(elt, 'hx-' + verb);
                     explicitAction = true;
                     nodeData.path = path;
@@ -1334,9 +1339,11 @@ return (function () {
                 unfilteredParameters:rawParameters,
                 headers:headers,
                 target:target,
-                verb:verb
+                verb:verb,
+                path:path
             };
             if(!triggerEvent(elt, 'configRequest.htmx', requestConfig)) return endRequestLock();
+            path = requestConfig.path;
 
             var splitPath = path.split("#");
             var pathNoAnchor = splitPath[0];

diff --git a/test/core/ajax.js b/test/core/ajax.js
@@ -412,6 +412,7 @@ describe("Core htmx AJAX Tests", function(){
     window.callGlobal = function() {
         globalWasCalled = true;
     }
+
     it('script nodes evaluate', function()
     {
         try {
@@ -425,5 +426,29 @@ describe("Core htmx AJAX Tests", function(){
         }
     });
 
+    it('allows empty verb values', function()
+    {
+        var path = null;
+        var div = make("<div hx-get=''/>");
+        htmx.on(div, "configRequest.htmx", function (evt) {
+            path = evt.detail.path;
+            return false;
+        });
+        div.click();
+        path.should.not.be.null;
+    });
+
+    it('allows blank verb values', function()
+    {
+        var path = null;
+        var div = make("<div hx-get/>");
+        htmx.on(div, "configRequest.htmx", function (evt) {
+            path = evt.detail.path;
+            return false;
+        });
+        div.click();
+        path.should.not.be.null;
+    });
+
 
 })