Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return false from callbacks to prevent default behavior #6

Conversation

davidalejandroaguilar
Copy link
Contributor

@davidalejandroaguilar davidalejandroaguilar commented Mar 24, 2023

This adds the possibility of stopping a behavior from a callback if it returns false, as it's done on morphdom.

@1cg
Copy link
Contributor

1cg commented Mar 28, 2023

Hi david,

Looks good, would you mind adding some tests for the change?

@davidalejandroaguilar
Copy link
Contributor Author

@1cg My bad, didn't notice we had a tests folder, I'll add them.

@1cg
Copy link
Contributor

1cg commented May 3, 2023

hey @davidalejandroaguilar just checking in on this, would like to merge w/ some tests

@tobyzerner
Copy link

Looking forward to this being merged - in my case, idiomorph is trying to merge <svg> child elements where I just want the entire new <svg> to overwrite the old.

@1cg
Copy link
Contributor

1cg commented May 30, 2023

OK, merging w/o tests. I will add some later. (lol)

@1cg 1cg merged commit 6d837e1 into bigskysoftware:main May 30, 2023
@daun
Copy link

daun commented Sep 7, 2023

This looks fantastic! @1cg Any chance this could be released? As far as I can tell, the current release on npm doesn't include the changes from this PR.

@1cg
Copy link
Contributor

1cg commented Sep 7, 2023

i will try to cut a release tomorrow

@daun
Copy link

daun commented Sep 7, 2023

🤠

@1cg
Copy link
Contributor

1cg commented Sep 11, 2023

should be available in the latest release on NPM

@davidalejandroaguilar
Copy link
Contributor Author

I just noticed I abandoned this PR 🤦🏼‍♂️ . My apologies @1cg, life got in the way but absolutely didn't mean to ghost you.

Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants