Fix Tabs and Menu Components That Cannot Access JavaScript Files #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes, pls merge this, currently tabs/menus does not work if one follows the documentation. Missing.js seems very nice, but currently it does not inspire confidence :) |
|
Thanks for the fix! The whole packaging and distribution story for missing was overhauled a while ago, and I haven't been able to come back to fix all the rough edges. Looks like the copied files snuck into the commit -- could you remove them and add them to .gitignore? Otherwise LGTM |
added 2 commits
January 26, 2024 19:52
…like 40-aria.md can function when deployed to Netlify.
|
Removed the copied files, updated the gitignore, and rebased on the latest dev branch. |
|
Great work, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build step copies
dist/jsintowww/missing-jsso components in pages like40-aria.mdcan function when deployed to Netlify.I see other JS was contributed to the
wwwfolder, so I mirrored that structure. If I should modify it in any way please let me know.