Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert str.format to f-strings #138

Merged
merged 4 commits into from
Feb 5, 2024
Merged

chore: Convert str.format to f-strings #138

merged 4 commits into from
Feb 5, 2024

Conversation

sellth
Copy link
Collaborator

@sellth sellth commented Jan 29, 2024

Converted .format and % operator to f-strings where it improves readability and does not clash with the 100 character line length limit.

closes #116

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (02f096d) 96.52% compared to head (fa8320d) 96.98%.
Report is 1 commits behind head on master.

Files Patch % Lines
altamisa/isatab/validate_assay_study.py 17.64% 14 Missing ⚠️
altamisa/apps/isatab2dot.py 83.33% 2 Missing ⚠️
altamisa/isatab/validate_investigation.py 89.47% 2 Missing ⚠️
altamisa/isatab/write_assay_study.py 0.00% 2 Missing ⚠️
tests/test_write_assay.py 66.66% 1 Missing ⚠️
tests/test_write_study.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   96.52%   96.98%   +0.45%     
==========================================
  Files          29       29              
  Lines        3426     3380      -46     
==========================================
- Hits         3307     3278      -29     
+ Misses        119      102      -17     
Flag Coverage Δ
python 96.98% <71.42%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sellth
Copy link
Collaborator Author

sellth commented Jan 29, 2024

Will move snapshot testing into separate PR to make reviewing easier.

@holtgrewe holtgrewe merged commit 4ad091e into master Feb 5, 2024
9 of 10 checks passed
@holtgrewe holtgrewe deleted the f_strings branch February 5, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comprehensively use f-strings
2 participants