Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samplesheets: Refactor column type determining #730

Closed
3 tasks done
mikkonie opened this issue Nov 27, 2019 · 7 comments
Closed
3 tasks done

Samplesheets: Refactor column type determining #730

mikkonie opened this issue Nov 27, 2019 · 7 comments
Assignees
Labels
internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Milestone

Comments

@mikkonie
Copy link
Contributor

The old style is not optimal now that we have initial editing and JSON configuration included.

Tasks

@mikkonie
Copy link
Contributor Author

mentioned in commit 985b9f16344f485de28d5afc58ef861b942e735a

@mikkonie
Copy link
Contributor Author

marked the task Check/alter value in _add_header() and/or _add_cell() where applicable as completed

@mikkonie
Copy link
Contributor Author

mikkonie commented Dec 2, 2019

mentioned in commit 16a99ac

@mikkonie
Copy link
Contributor Author

mikkonie commented Dec 2, 2019

marked the task Use JSON configuration if present, override other methods as completed

@mikkonie
Copy link
Contributor Author

mikkonie commented Dec 2, 2019

marked the task Update types dynamically when editing column configuration in UI, see #698 as completed

@mikkonie
Copy link
Contributor Author

mikkonie commented Dec 2, 2019

Done.

@mikkonie
Copy link
Contributor Author

mikkonie commented Dec 2, 2019

closed

@mikkonie mikkonie self-assigned this Jun 15, 2022
HaraldWilhelmi pushed a commit to dieterich-lab/sodar-server that referenced this issue Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Projects
None yet
Development

No branches or pull requests

1 participant