Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize JSON data provided to samplesheets Vue app #708

Closed
7 tasks done
mikkonie opened this issue Nov 14, 2019 · 9 comments
Closed
7 tasks done

Optimize JSON data provided to samplesheets Vue app #708

mikkonie opened this issue Nov 14, 2019 · 9 comments
Assignees
@mikkonie
Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Nov 14, 2019 •
edited

With large studies the JSON data can grow quite large. It also contains a lot of non-applicable members always populated:
@mikkonie
Copy link
Contributor Author

marked the task Only provide link_file for relevant cells as completed

@mikkonie
Copy link
Contributor Author

mentioned in commit 35cd804

@mikkonie
Copy link
Contributor Author

mentioned in commit 6212fef

@mikkonie
Copy link
Contributor Author

marked the task Only provide tooltip when filled out as completed

@mikkonie
Copy link
Contributor Author

mikkonie commented Dec 2, 2019

mentioned in commit 16a99ac

@mikkonie
Copy link
Contributor Author

mikkonie commented Dec 2, 2019

marked the task Make link and unit rendering dynamic (requires refactoring column type and length checks) as completed

@mikkonie
Copy link
Contributor Author

mentioned in commit b62d2da

@mikkonie
Copy link
Contributor Author

marked the task Remove redundant num_col and align members as completed

@mikkonie mikkonie self-assigned this Jun 15, 2022
@mikkonie mikkonie changed the title Samplesheets: Optimize JSON data provided to Vue app Optimize JSON data provided to samplesheets Vue app Jun 15, 2022
@mikkonie mikkonie added app: samplesheets Issue in the samplesheets app and removed ongoing Ongoing issue, needs observation or pending on other projects labels Jun 15, 2022
@mikkonie mikkonie mentioned this issue Oct 31, 2022
Closed
8 tasks
mikkonie added a commit that referenced this issue Dec 6, 2022
@mikkonie
remove redundant render table uuids (#708)
3c217d2
@mikkonie
Copy link
Contributor Author

mikkonie commented Dec 6, 2022

All tasks mentioned in the spec have been done. More optimization is definitely possible in the future, but considering this issue closed.

@mikkonie mikkonie closed this as completed Dec 6, 2022
mikkonie added a commit that referenced this issue Dec 12, 2022
@mikkonie
add study render table caching (#1509), update rendering (#708, #1550,#…
cd5449a 
…1551)
HaraldWilhelmi pushed a commit to dieterich-lab/sodar-server that referenced this issue Sep 22, 2023
@mikkonie
remove unused link_file rendering parameter (bihealth#708)
35cd804
HaraldWilhelmi pushed a commit to dieterich-lab/sodar-server that referenced this issue Sep 22, 2023
@mikkonie
optimize tooltip rendering (bihealth#708), cleanup DataCellRenderer
6212fef
HaraldWilhelmi pushed a commit to dieterich-lab/sodar-server that referenced this issue Sep 22, 2023
@mikkonie
refactor column type detection (bihealth#730), make link and unit ren…
16a99ac 
…dering dynamic (bihealth#708)
HaraldWilhelmi pushed a commit to dieterich-lab/sodar-server that referenced this issue Sep 22, 2023
@mikkonie
init column manage modal values by column content (bihealth#698), opt…
b62d2da 
…imize column type and align rendering (bihealth#708), vue app refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikkonie