Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma as decimal separator #581

Closed
leonardorojass opened this issue Jan 31, 2013 · 6 comments
Closed

Comma as decimal separator #581

leonardorojass opened this issue Jan 31, 2013 · 6 comments

Comments

@leonardorojass
Copy link

The system should allow to use comma (,) as the decimal separator in results (or calculations, reports, ect.) for SI system users.


Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

@lemoene
Copy link
Contributor

lemoene commented Feb 2, 2013

@lemoene
Copy link
Contributor

lemoene commented Aug 23, 2013

Was this one resolved Leo?

@leonardorojass
Copy link
Author

I was thinking about it yesterday. I am not sure where shall I change from point to comma as decimal mark in the configuration setup? Does it is in Bika setup or in zope setup? The system always has point mark as default.

@lemoene lemoene modified the milestones: LIMS Trunk Feature Requests, Bika 3.1 May 3, 2014
@xispa
Copy link
Contributor

xispa commented Jun 11, 2014

For tracking purposes, copy&paste from users list:

Right now, Bika LIMS only has support for the english version of decimal mark, the dot, which is the Python's standard decimal mark.

The Bika LIMS input fields in forms are mostly managed by Plone's Archetypes framework, so we don't usually need to use any specific code logic for saving content-type field values, taking advantage of Archetypes. Until now, Archetypes didn't have support for different decimal marks, but the latest version of Products.Archetypes, which was delivered last week (1.9.8 - 2014-06-03) allows commas as decimal marks for input in float fields. Even though, this improvement only converts the 'comma' character from float fields to dot character when the content-type gets saved, so we'd still need to convert the float value again to the user's current locale in all places where the float value is displayed.

@lemoene
Copy link
Contributor

lemoene commented Jun 16, 2014

I cannot find the mail where Campbell suggested that a Plone patch fixed the issue, can you trace it leo an paste in here please, leo i'm on a manic schedule at the moment

the issue with issues raised in private, i think we should be stricter in channelling all general subjects through the lists (discussions) and tracker (issues)

At the same time leo mentioned that usinf SI in their ISO 17025 documents, and the issue might see the lab fail their audit. which made we wonder how she passed audits for 10 years in ZA, and some in Canada that I know of in the decimal point configuration

Note to self find out

@rockfruit
Copy link
Contributor

Took this out of 3.1 - there is actually quite a bit of code that needs testing for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants