New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIMS-2321: Allow multiple Methods per Instrument #1871
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Method field and widget. Changed Instrument listing view. Changed Analysisservice view. Updated Changelog
Do not allow empty values into multiValued fields
Use Plural names for these, and change logic to support this.
It now reads 'Allow manual entry of results', and the intention is to remove the negative language that is confusing. If it's on, you can do it. If it's off, you can not do it.
Shall we close this in favor of #1944? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow multiple Methods per Instrument
https://jira.bikalabs.com/browse/LIMS-2321
Please note
This PR introduces 2 new helper modules, which introduce functional helpers for the well-being of all Bika developers.
bika.lims.api
introduces framework helpers which interfaces with Plone/Bika (One function for a sinle purpose)bika.lims.utils.functools
introduces functional Python helpers (One function for a single purpose)Both modules are easy to extend and help (at least me) to write less and do more;)