Add is_full() to limited.

[Carter12s]

is_full() is a useful function and an existing method of the underlying crossbeam queue type. I believe exposing it has limited / no downsides and slightly improves usability.

Additionally expanded some doc strings around len() vs capacity() where I had initial (minor) confusion.

[Carter12s]

Note: I did look into adding is_full() to "Resizable", but implementation was non-obvious to me.

[bikeshedder]

For resizable you can just implement it like this:

pub fn is_full(&self) -> bool {
    self.len() >= self.capacity()
}

In theory it can give wrong values as it involves two atomic values which are read non-atomically, but it's as good as it can be implemented. It will only be wrong under rare circumstances: push/pop while a resize is happening

is_full() should never be used to decide whether to push or not. Any real world code should just call try_push instead.

Could you add this to the PR and while you're at it add a 0.2.3 - unreleased to the CHANGELOG documenting those changes?

[bikeshedder]

Also please add a test for it. This feature is trivial for the limited implementation so a test won't be necessary here. At least theresizable contains a small amount of logic and a test would be "nice to have". I'll also merge it without tests. It would just be the cherry on top. 😉

[Carter12s]

Excellent suggestions. Pushed changes with updated changelog, resizable impl of is_full, and a (basic) test case for resizable.

[bikeshedder]

Thanks a lot! 👍

I just uploaded version 0.2.3 to crates.io: https://crates.io/crates/deadqueue/0.2.3