Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conversion from WindowIdentifier to raw_window_handle::RawWindowHandle #40

Closed
Be-ing opened this issue Jan 18, 2022 · 1 comment · Fixed by #41
Closed

conversion from WindowIdentifier to raw_window_handle::RawWindowHandle #40

Be-ing opened this issue Jan 18, 2022 · 1 comment · Fixed by #41

Comments

@Be-ing
Copy link
Contributor

Be-ing commented Jan 18, 2022

raw_window_handle is a cross platform library abstracting over window handles for various windowing systems, including Wayland and X11. For cross platform code using ashpd, for example rfd, it would be helpful for ashpd to provide an API to convert its WindowIdentifier type to raw_window_handle's RawWindowHandle type. Alternatively, perhaps ashpd could switch to using RawWindowHandle in its own API.
@Be-ing Be-ing mentioned this issue Jan 18, 2022
Merged
@bilelmoussaoui bilelmoussaoui mentioned this issue Jan 18, 2022
Merged
Be-ing added a commit to Be-ing/rfd that referenced this issue Jan 18, 2022
@Be-ing
add link to ashpd issue for RawWindowHandle
503aa10 
bilelmoussaoui/ashpd#40
PolyMeilex pushed a commit to PolyMeilex/rfd that referenced this issue Jan 18, 2022
@Be-ing
Add suport for XDG Desktop Portal on Linux & BSDs (#41)
e331eff 
* use XDG Desktop Portal on Linux & BSDs

This new backend does not support MessageDialog nor
AsyncMessageDialog because there is no corresponding API in the
XDG Desktop Portal.

The GTK backend is still available with the new `gtk3` Cargo
feature.

Fixes #36

* replace smol with pollster

pollster is smaller than smol

* rename unwrap_or_warn to ok_or_warn

* reuse async functions to implement sync functions

* replace Option::ok with ok_or_warn

* impl From<FileHandle> for PathBuf

to reduce code duplication

* cargo fmt

* factor out file_chooser_proxy function

* add link to ashpd issue for RawWindowHandle

bilelmoussaoui/ashpd#40

* make gtk3 a default feature
@PolyMeilex PolyMeilex mentioned this issue Jan 19, 2022
Open
@bilelmoussaoui
Copy link
Owner

Closed this in favour of the remaining part at #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

window identifier: provide a way API around raw-window-handle bilelmoussaoui/ashpd
2 participants
@bilelmoussaoui @Be-ing