add not implemented errors where needed #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
billiford
commented
Oct 13, 2020
billiford
commented
- add errors when trying to scale or perform a rolling restart on an unsupported kind
- add error when trying to patch using an unsupported merge type
- add error when trying to resolve unsupported artifact type
iteaguy
reviewed
Oct 13, 2020
| @@ -73,6 +73,17 @@ var _ = Describe("Restart", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| When("the kind is not supported to restarted", func() { | |||
| BeforeEach(func() { | |||
| actionConfig.Operation.RollingRestartManifest.ManifestName = "not-supported-kind test-name" | |||
There was a problem hiding this comment.
Shuldnt this be?:
actionConfig.Operation.RollingRestartManifest.ManifestName = “not-supported-kind”?
to match the message in Line #83
There was a problem hiding this comment.
This is one aspect of the Spinnaker API that I've always found weird. When referencing a manifest by name it is almost always referenced as <kind> <name>, which is what I'm doing here.
iteaguy
reviewed
Oct 13, 2020
| @@ -84,6 +84,17 @@ var _ = Describe("Scale", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| When("the kind is not supported to scale", func() { | |||
| BeforeEach(func() { | |||
| actionConfig.Operation.ScaleManifest.ManifestName = "not-supported-kind test-name" | |||
There was a problem hiding this comment.
Shuldnt this be?:
actionConfig.Operation.ScaleManifest.ManifestName = “not-supported-kind”?
to match the message in Line #94
billiford
added a commit
that referenced
this pull request
May 13, 2023
* associate server groups and managers using UID * fix linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.