Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Gaurd against errors when being nested in other plugins #58

Merged
merged 2 commits into from
Mar 10, 2017

Conversation

billybonks
Copy link
Owner

index.js Outdated
@@ -9,6 +9,20 @@ module.exports = {

included: function(app) {
//shared
var app;

// If the addon has the _findHost() method (in ember-cli >= 2.7.0), we'll just

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.

index.js Outdated
@@ -9,6 +9,20 @@ module.exports = {

included: function(app) {
//shared
var app;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'app' is already defined.

onError: function(results) {
errors.push(results);
},
console:console

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'console' is not defined.

}
});
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

//guard see https://github.com/ember-cli/ember-cli/issues/3718
var app;

// If the addon has the _findHost() method (in ember-cli >= 2.7.0), we'll just

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.

@billybonks billybonks merged commit 6c33049 into master Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants