Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alberta's public key #36

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Add Alberta's public key #36

merged 1 commit into from
Oct 8, 2021

Conversation

grepme
Copy link

@grepme grepme commented Oct 8, 2021

After much searching, I have finally stumbled upon Alberta's public key. I confirmed it against my personal QR Code.

Copy link
Collaborator

@straxus straxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo!

@straxus straxus merged commit b5e09a7 into billylo1:main Oct 8, 2021
abramhindle added a commit to abramhindle/shc-extractor that referenced this pull request Oct 8, 2021
@corrmaan
Copy link

@grepme and @straxus Wondering if you could please elaborate on how you find the public keys. I'm looking to do the same for Nova Scotia.

@straxus
Copy link
Collaborator

straxus commented Oct 12, 2021

@grepme and @straxus Wondering if you could please elaborate on how you find the public keys. I'm looking to do the same for Nova Scotia.

Has Nova Scotia released an SHC QR code yet? If so, then you will want to decode it and look for a code block that looks like this: https://github.com/billylo1/covidpass/blob/shc-refactoring/examples/shc-ca-bc-decoded.json#L2

for this Issuer (https://smarthealthcard.phsa.ca/v1/issuer), the public key is at https://smarthealthcard.phsa.ca/v1/issuer/.well-known/jwks.json as this is required by the SHC standard (issuer URL + /.well-known/jwks.json)

@corrmaan
Copy link

corrmaan commented Oct 12, 2021

Yes they released it on October 4, 2021.

Many thanks for the info, I'll dig into it in the next few days. I've decoded my SHC QR already and have the issuer link, so your helpful key link might be all that's required for me to make a PR.

I imagine that other code edits will be necessary, and that hopefully I'll discover them with some testing.

@straxus
Copy link
Collaborator

straxus commented Oct 12, 2021

Yes they released it on October 4, 2021.

Many thanks for the info, I'll dig into it in the next few days. I've decoded my SHC QR already and have the issuer link, so your helpful key link might be all that's required for me to make a PR.

I imagine that other code edits will be necessary, and that hopefully I'll discover them with some testing.

Fantastic, thank you very much!! And it would be extremely helpful as part of that PR if you could add an example (with all info redacted) to the examples/ folder I pointed at in the previous comment as it helps to understand similarities and differences between the QR codes for different provinces. If you can put that example and the public key into a PR against shc-refactor, I can take it from there on the current shc-refactor branch (that's approaching completion already, and has more generalized multi-jurisdiction support compared to current main branch).

Thanks!

@corrmaan
Copy link

Oops, I made #37 before I read your comment! I'll work on making an example for NS in the next few days. They're also releasing their app on Oct 22 so there's a bit of time yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants