Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxing ruby 2.5 version and silencing RVM warning #303

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

dgilperez
Copy link
Contributor

This PR makes it possible to cope with Ruby 2.5 patch versions (2.5.5 for instance).

It also moves from .rvmrc to newer .ruby-version and .ruby-gemset as suggested by RVM itself:

You are using '.rvmrc', it requires trusting, it is slower and it is not compatible with other ruby managers,
you can switch to '.ruby-version' using 'rvm rvmrc to ruby-version'
or ignore this warning with 'rvm rvmrc warning ignore /Users/dgilperez/src/i4a/seal/.rvmrc',
'.rvmrc' will continue to be the default project file in RVM 1 and RVM 2,
to ignore the warning for all files run 'rvm rvmrc warning ignore all.rvmrcs'.


  • NOTICE *

  • RVM has encountered a new or modified .rvmrc file in the current directory, this is a shell script and *
  • therefore may contain any shell commands. *
  •                                                                                                             *
    
  • Examine the contents of this file carefully to be sure the contents are safe before trusting it! *
  • Do you wish to trust '/Users/dgilperez/src/i4a/seal/.rvmrc'? *
  • Choose v[iew] below to view the contents *

Copy link
Owner

@binaryberry binaryberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution David!

@binaryberry binaryberry merged commit a9a069b into binaryberry:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants