Fixed Test Errors on Rails 4 #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 6, 2013 14:34
| @@ -11,8 +11,8 @@ Gem::Specification.new do |s| | |||
| s.summary = %q{A clean, simple, and unobtrusive ruby authentication solution.} | |||
| s.description = %q{A clean, simple, and unobtrusive ruby authentication solution.} | |||
|
|
|||
| s.add_dependency 'activerecord', '>= 3.0.0' | |||
| s.add_dependency 'activesupport', '>= 3.0.0' | |||
| s.add_dependency 'activerecord', '>= 4.0.0.beta1' | |||
There was a problem hiding this comment.
I'm guessing we'd still want to support and test against Rails 3. I hope #368 will help.
|
I believe we're using appraisal now to test both versions of rails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ben,
I am using Rails 4 beta for ActiveRecord and ActiveSupport. Doing
rake testgot me some (nine I think) errors. They were because:I am sure you're aware of the deprecation warnings related to scope. They remain because I am not entirely sure about what's really happening there. But will try to fix things when I find more time. Meanwhile, getting this PR in will be great. Thanks :o)