Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's start testing against Rails 3 and Rails 4 #368

Merged
merged 4 commits into from
Jul 26, 2013
Merged

Let's start testing against Rails 3 and Rails 4 #368

merged 4 commits into from
Jul 26, 2013

Conversation

nathany
Copy link
Contributor

@nathany nathany commented Jun 14, 2013

This pull request sets up Appraisal to test against multiple versions of Rails, and also contains a Travis.ci config against multiple versions of Ruby.

A first step towards Rails 4 support. Yes, there are test failures. That's kind've the point.

rake appraisal:install
rake appraisal

This was referenced Jun 14, 2013
@nathany
Copy link
Contributor Author

nathany commented Jun 14, 2013

Here's the documentation for .travis.yml, in particular there is an allow_failures block that can be used if testing against dev versions of Ruby or Rails master. See also Testing against multiple Rails version.

@nathany
Copy link
Contributor Author

nathany commented Jun 25, 2013

@binarylogic Any plans to support Rails 4?

@xinuc
Copy link

xinuc commented Jun 27, 2013

+1

5 similar comments
@defkode
Copy link

defkode commented Jun 27, 2013

+1

@nathanbertram
Copy link

+1

@raarellano
Copy link

+1

@tiegz
Copy link
Contributor

tiegz commented Jul 17, 2013

+1

@joscas
Copy link

joscas commented Jul 23, 2013

+1

@nathany
Copy link
Contributor Author

nathany commented Jul 26, 2013

I don't think anyone is home?

A "friendly fork" may be in order, unless @binarylogic gives someone else permission to merge pull requests and push the gem.

binarylogic added a commit that referenced this pull request Jul 26, 2013
Let's start testing against Rails 3 and Rails 4
@binarylogic binarylogic merged commit 3255c37 into binarylogic:master Jul 26, 2013
@binarylogic
Copy link
Owner

Anyone care to help getting the tests passing for 3 and 4? Then I can bump the version.

@nathany
Copy link
Contributor Author

nathany commented Jul 26, 2013

Thanks @yourewelcome. Fyi, the Travis support included in this merge requires a GitHub service hook: Getting Started.

Then tests should be running at: https://travis-ci.org/binarylogic/authlogic as well as on pull requests.

@binarylogic
Copy link
Owner

Setting it up now

@binarylogic
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants