Resolve #406 - exit_binding_identifier now handles lazy functions #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
reviewed
May 2, 2019
crates/binjs_es6/src/scopes.rs
Outdated
| fn exit_eager_function_declaration( | ||
| &mut self, | ||
| path: &WalkPath, | ||
| node: &mut EagerFunctionDeclaration, | ||
| ) -> ExitResult<EagerFunctionDeclaration> { | ||
| debug!(target: "annotating", "exit_eager_function_declaration {:?} at {:?}", node.name.name, path); | ||
| self.exit_lazy_or_eager_function_declaration(path, &node.name)?; |
There was a problem hiding this comment.
In all of these, it seems you could just write:
self.exit_lazy_or_eager_function_declaration(path, &node.name)to return result immediately?
There was a problem hiding this comment.
The return type is different, unfortunately.
There was a problem hiding this comment.
Ah. I guess you can make that function generic to return any ExitResult<T>?
|
Seems fine by me, but I'll better leave it to you and @arai-a :) |
|
@Yoric Although, could you maybe change or re-enable tests responsible for lazification as part of this? |
exit_binding_identifier contains a hard-coded list of nodes that represent functions. This is hardly ideal (perhaps we should somehow put this in the webidl?) and at some point, we failed to update this list, causing the bug. Also: - removing some dead code; - making sure that test_roundtrip covers this case.
Yoric
force-pushed
the
entropy-0.4.1-annotations
branch
from
3ad82e7
to
ea402a8
Compare
RReverser
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exit_binding_identifier contains a hard-coded list of nodes that represent
functions. This is hardly ideal (perhaps we should somehow put this in the webidl?)
and at some point, we failed to update this list, causing the bug.