-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 500 feature add reference secret manager implementation demoapps #503
Merged
marianod92
merged 14 commits into
master
from
issue-500-feature-add-reference-secret-manager-implementation-demoapps
Apr 28, 2023
Merged
Issue 500 feature add reference secret manager implementation demoapps #503
marianod92
merged 14 commits into
master
from
issue-500-feature-add-reference-secret-manager-implementation-demoapps
Apr 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💰 Infracost estimate: monthly cost will not change
128 projects have no cost estimate changes, 1 project could not be evaluated. Infracost output
This comment will be updated when the cost estimate changes. Is this comment useful? Yes, No, Other |
Franr
reviewed
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments!
apps-devstg/us-east-1/k8s-eks-demoapps/k8s-components/security.tf
Outdated
Show resolved
Hide resolved
diego-ojeda-binbash
requested changes
Apr 24, 2023
Franr
previously approved these changes
Apr 27, 2023
Franr
approved these changes
Apr 28, 2023
angelofenoglio
approved these changes
Apr 28, 2023
diego-ojeda-binbash
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add example implementation of Secrets Manager and how to consume secrets from EKS
Why?
To have basic implementation as an example for using Secrets Manager from some workload in EKS, particularly on the reference code of k8s-eks-demoapps reference code.