Enhancement | Remove empty provider configuration block warning

[angelofenoglio]

What

• Update module to fix "Empty provider configuration block" warning.

Why

To get rid of the message:

╷
│ Warning: Empty provider configuration blocks are not required
│ 
│   on .terraform/modules/terraform_backend/config.tf line 5:
│    5: provider "aws" {
│ 
│ Remove the aws.main_region provider block from module.terraform_backend. Add aws.main_region to the list of configuration_aliases for aws in required_providers to define the provider
│ configuration name.
│ 
│ (and one more similar warning elsewhere)
╵

when using this module.

[diego-ojeda-binbash]

@angelofenoglio So the fix is only this piece here, right?
I mean, to use the module you need to pass these providers:

providers = {
    aws           = aws
    aws.secondary = aws.secondary
}

So, I'm wondering if it'd be better to rather do it this way:

providers = {
    aws.primary   = aws
    aws.secondary = aws.secondary
}

That is, in order to follow the "Explicit is better than implicit." aphorism. What do you think?

[angelofenoglio]

Seems reasonable, I'll make these changes then!

[diego-ojeda-binbash]

Oh, is that right? I would've thought that the following is implicit:

resource "foo" "bar" {
    ...
    provider = aws
    ...
}

And thus it does not need to be explicitly defined.

[exequielrafaela]

@angelofenoglio the PR looks very good :)

Small comment regarding CI failing

I think you've already fixed this in another repo

• https://app.circleci.com/pipelines/github/binbashar/terraform-aws-tfstate-backend/118/workflows/0aa4584f-b7fc-4d46-8796-c443739ece82/jobs/214

pre-commit run --all-files
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'fetch', 'origin', '--tags')
return code: 128
expected return code: 0
stdout: (none)
stderr:
    fatal: remote error: 
      The unauthenticated git protocol on port 9418 is no longer supported.
    Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
    
Check the log at /home/circleci/.cache/pre-commit/pre-commit.log
make: *** [@bin/makefiles/terratest14/terratest14.mk:84: pre-commit] Error 3

Exited with code exit status 2
CircleCI received exit code 2

Regarding tests here https://github.com/binbashar/terraform-aws-tfstate-backend/blob/master/tests/verify_output_test.go we'll need to update the examples to cover the new module version

• https://app.circleci.com/pipelines/github/binbashar/terraform-aws-tfstate-backend/118/workflows/0aa4584f-b7fc-4d46-8796-c443739ece82/jobs/215

So if this will stop you from delivering your work please leave an issue in the repo and we can pull it as soon as possible. In general is very important to consider the tests effort, but we can do an exception this time.

CC: @binbashar/leverage-project-terraform-admin @binbashar/leverage-project-terraform-dev

[angelofenoglio]

@exequielrafaela Oh sure! I've just fixed the pre-commit issue!
I just wanted to trigger the CI jobs, since this is my first contribution in a module and I wasn't sure how it would behave. I'll now update the tests accordingly to make them pass.