Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use assume_role block for role_arn #28

Merged
merged 2 commits into from Jan 24, 2024

Conversation

d3adb5
Copy link
Contributor

@d3adb5 d3adb5 commented Oct 12, 2023

Use the assume_role.role_arn property instead of the now deprecated role_arn. This should also fix potential issues with the AWS provider trying to assume a nonexistent role.

what

  • Moved role_arn in the generated backend configuration into the assume_role
    block.

why

  • The role_arn configuration property is now deprecated in favor of the
    assumeassume_role block. This change deals with the issued warning and with
    potential issues involving the Terraform AWS provider being unable to assume a
    role that doesn't exist.

references

Use the assume_role.role_arn property instead of the now deprecated role_arn.
This should also fix potential issues with the AWS provider trying to assume a
nonexistent role.
@d3adb5
Copy link
Contributor Author

d3adb5 commented Oct 12, 2023

Not too sure what to make of the issues pointed out in the Checkov status check: I do see them showing up in a scan with tfsec, but fixing them is unfortunately out of the scope of this pull request, in my opinion.

Let me know how you guys wish to address that.

@martingaleano
Copy link
Contributor

Not too sure what to make of the issues pointed out in the Checkov status check: I do see them showing up in a scan with tfsec, but fixing them is unfortunately out of the scope of this pull request, in my opinion.

Let me know how you guys wish to address that.

I don't know if there is a specific reason to create the replication bucket with this set up, but maybe for future issues, we can add a comment inside resource block in order to skip the checkov validation (Ref: https://www.checkov.io/2.Basics/Suppressing%20and%20Skipping%20Policies.html)

@martingaleano martingaleano merged commit 44ed228 into binbashar:master Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants