-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not set CONAN_DOCKER_ENTRY_SCRIPT, but append instead #41
Conversation
This would allow installing system packages for example
conan_docker_entry_script = os.environ.get("CONAN_DOCKER_ENTRY_SCRIPT", '') | ||
if conan_docker_entry_script: | ||
conan_docker_entry_script += "; " | ||
conan_docker_entry_script += ( | ||
"conan config set storage.download_cache='{}'; " | ||
"conan config set general.revisions_enabled=1".format(tmpdir)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But out of curiosity, how are you planning to install system requirements?
We are setting CONAN_SYSREQUIRES_MODE=enabled
so CCI-styled Conan system packages should be able to install system packages
I'm mainly trying to do a workaround right now. I've solved my problem in the meantime but specifying an older tag via "dockerImage": "conanio/gcc8:1.46.2" so it wouldn't have this commit that removes libxxx-dev: conan-io/conan-docker-tools#446 Down the line I hope to just fix the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This would allow installing system packages for example
Similar to #35