Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set CONAN_DOCKER_ENTRY_SCRIPT, but append instead #41

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Sep 14, 2022

This would allow installing system packages for example

Similar to #35

This would allow installing system packages for example
Comment on lines +97 to +102
conan_docker_entry_script = os.environ.get("CONAN_DOCKER_ENTRY_SCRIPT", '')
if conan_docker_entry_script:
conan_docker_entry_script += "; "
conan_docker_entry_script += (
"conan config set storage.download_cache='{}'; "
"conan config set general.revisions_enabled=1".format(tmpdir))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough

Copy link
Member

@Croydon Croydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But out of curiosity, how are you planning to install system requirements?

We are setting CONAN_SYSREQUIRES_MODE=enabled so CCI-styled Conan system packages should be able to install system packages

@Croydon Croydon self-assigned this Sep 14, 2022
@jmarrec
Copy link
Contributor Author

jmarrec commented Sep 14, 2022

I'm mainly trying to do a workaround right now. I've solved my problem in the meantime but specifying an older tag via "dockerImage": "conanio/gcc8:1.46.2" so it wouldn't have this commit that removes libxxx-dev: conan-io/conan-docker-tools#446

Down the line I hope to just fix the issue.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Croydon Croydon merged commit 7918f2b into bincrafters:develop Sep 15, 2022
Croydon added a commit that referenced this pull request Oct 25, 2022
Croydon added a commit that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants