Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added possibility to integrate slide headers and footers #769

Closed
wants to merge 1 commit into from

Conversation

lpirl
Copy link
Contributor

@lpirl lpirl commented May 3, 2017

This is a quick hack to allow easier integration of slide headers and slide footers.
Example provided.

Without this patch, users are limited to specify headers and footers via templates within <div class="content …. When the aforementioned div does not fill the whole height of the presentation, a footer specified within a template does not really look like a footer (but rather like static content floating around in the middle of the screen).

Sadly, I will abandon Showoff for my current purpose, so I probably won't put more effort into this PR, but feel very free to merge this – I'd be happy if it is of any help.

Thanks for this cool project!

@marrero984
Copy link
Contributor

@lpirl It's a good idea to include headers and footers, but I'm not sure if this is the way to add them in. I can see a couple of places where it would interfere with the current design and layout.

I'm going to wait for @binford2k to get back and we'll discuss it. Thanks for contributing.

@lpirl
Copy link
Contributor Author

lpirl commented May 3, 2017

True, I wasn't too happy with this implementation either but it was the best place I could find and I tried not to break existing functionality. To be honest, I think a "proper" template system (including template inheritance etc.) would be a very beneficial feature as well. Thanks for considering.

@marrero984
Copy link
Contributor

@lpirl We're not going to merge this. You can add a header and/or footer using the existing templates functionality. It is not great, but it works. We will be reworking this and will definitely keep it in mind

@marrero984 marrero984 closed this May 11, 2017
@lpirl
Copy link
Contributor Author

lpirl commented May 12, 2017

You can add a header and/or footer using the existing templates functionality.

Can you? As mentioned in the OP, I was confronted with the problem that the templates are placed within <div class="content … and when the latter does not have a full height (e.g., on title slides), the footer floats around in the middle of the slide, what is not acceptable.
If one places the HTML elements for the header/footer at the top of the template, the outline shows the header/footer text for every item, which is not acceptable either.

I am sure I was lacking CSS ninja skills :) If you could provide an example, I am sure folks who come across this issue would be happy.

@binford2k
Copy link
Owner

@lpirl I am going to rework (and clean up) the templating a bit to add the header/footer functionality you want. I believe that's the layer it belongs in, rather than in another markdown file. I'll reuse some of your ideas and will attribute you as a co-author.

Right now, you can do that with the templating layer, but yes it does take a bit of css weirdness. You'd add a header div and a footer div in the template and position them fixed using a custom stylesheet.

@binford2k binford2k mentioned this pull request May 12, 2017
3 tasks
@lpirl
Copy link
Contributor Author

lpirl commented May 13, 2017

Alright, fixed to place text at the edges of the screen (and not the slide), fair enough.
Thanks for planned work on this and attribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants