Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename libdash library to avoid name collision in dune #29

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

mgree
Copy link
Collaborator

@mgree mgree commented Feb 2, 2024

Applying a fix from @emillon in ocaml/dune#9773 seems to produce a shell_to_json and json_to_shell that function and I'm able to link against the library. 🎉

@mgree mgree added bug Something isn't working pash PaSh labels Feb 2, 2024
This was referenced Feb 2, 2024
@mgree mgree closed this Feb 4, 2024
@mgree mgree reopened this Feb 4, 2024
@mgree mgree merged commit a39be0e into master Feb 4, 2024
19 of 20 checks passed
@mgree mgree deleted the dune-9773 branch February 4, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pash PaSh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant