Web App: Strings with issues

[StoyanDimitrov]

• notifications_loading aren't we talking about messages everywhere in the web app UI?
• publish_dialog_attachment_limits_quota_reached missing space after the comma
• what are the gotchas when translating publish_dialog_delay_placeholder?

[binwiederhier]

notifications_loading

It's a horrible mix of "message" and "notification". I see that now.

The pubsub protocol calls it message, but the UI typically calls it notification. But a notification has a message in the JSON, so 🤷 Let me review it all.

publish_dialog_delay_placeholder

"tomorrow, 9am" -- Only English is supported, so I'd leave that.

[binwiederhier]

I think I fixed the notification/message thing and your other comments, as per d2f933e

"Message" only appears now when the message body is referenced.

[StoyanDimitrov]

I feel like prefs_notifications_min_priority_title - "Minimum priority" needs some explanation. It's not immediately clear where this setting applies. The Android app has brief description that gives the needed context.

[binwiederhier]

"Minimum priority" needs some explanation.

Hmm. You may be right. I'd have to add some detailed description text for each of the settings. Let me think about how to do that in the UI 🤔

[binwiederhier]

What do you think?

[StoyanDimitrov]

Looking good. It's nice addition.

[StoyanDimitrov]

Is it possible on notifications_no_subscriptions_description (Click the "Add subscription" link to create or subscribe to a topic. After that, you can send messages via PUT or POST and you'll receive notifications here.) to use placeholder with the actual button label - nav_button_subscribe? The text of the button already changed to "Subscribe to topic".

[binwiederhier]

Done.

[binwiederhier]

I'll close this for now, but you can keep adding if you find more issues.