-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: UnifiedPush registration with Schildichat broken since v1.11.0 #230
Comments
As said on Discord, to me it looks like Schildi is sending the same registration twice within 5ms:
Looking at binwiederhier/ntfy-android@v1.10.0...v1.11.0 (only (i) got rid of My question to the UP guys (@karmanyaahm, @p1gp1g, @sparchatus) (a) is the way that ntfy behaves (in the latest version, see log) now correct? |
My guess is that (i) is incorrect, because: same app + same token -> return NEW_ENDPOINT, right? |
Yes, as Sparchatus said in the chat, it should return the same endpoint again if there's another call with same params.
|
Hm, if I remember correctly, from @p1gp1g's implementation, it re-registered on every app start. Will have a look when I find time. |
Hi @SpiritCroc nice to meet you :-D I was going totally insane for a while, because GitHub search doesn't show any results for I briefly looked at the code, but not in an IDE, but it is entirely possible that |
Hi :)
Github search doesn't search code for projects with "fork" status unfortunately.
So will SchildiChat need changes, or is it fine as is? |
Hi ! Ntfy should resend the new endpoint when it receives a new registration :) https://unifiedpush.org/spec/android/#orgunifiedpushandroidconnectornew_endpoint
|
I mean while I of course agree, I think that the connector should maybe not send the same registration twice within 5ms (see above: I'll fix it on my end, np. |
I see, that indeed sounds unnecessary 🤔 |
Fixed in binwiederhier/ntfy-android@821a1ac -- this looks like a lot, but it's just a I tested with MacroDroid tapping a floating action button many times. Since that didn't work I added an artificial |
Second call is unnecessary, and can cause issues in the distributor: binwiederhier/ntfy#230 Change-Id: I53f8ea38b424e8b4cc27b76001cd182429fa9439
Fixed in SchildiChat now as well, it was indeed trying to register twice when clicking "re-register push distributor" - my fault, sorry. |
Nice. Thanks! |
As reported by Jakob on Discord:
The text was updated successfully, but these errors were encountered: