Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parameters accept only lowercase parameter names #630

Closed
bbaa-bbaa opened this issue Feb 22, 2023 · 4 comments
Closed

Query parameters accept only lowercase parameter names #630

bbaa-bbaa opened this issue Feb 22, 2023 · 4 comments
Labels
enhancement New feature or request server Relates to the main binary (server or client)

Comments

@bbaa-bbaa
Copy link

The parameter names are described as case-insensitive in the documentation, but only lowercase is accepted when passed by the query parameters

@binwiederhier binwiederhier added enhancement New feature or request server Relates to the main binary (server or client) labels Feb 23, 2023
@wunter8
Copy link
Contributor

wunter8 commented Mar 7, 2023

Is there a specific query parameter you're having problems with? All of the following work fine for me.

curl "https://ntfy.sh/mytopic/publish?message=testing"
curl "https://ntfy.sh/mytopic/publish?Message=testing"
curl "https://ntfy.sh/mytopic/publish?mEsSAgE=testing"

Never mind. I didn't notice that the message was triggered instead of testing when using the capital query parameters.

@binwiederhier
Copy link
Owner

As per #661 (comment), I think we're not going to do this. Instead, we'll just update the docs to reflect that query params are lower-case only.

@binwiederhier
Copy link
Owner

Changed in the docs:

The following is a list of all parameters that can be passed when publishing a message. Parameter names are case-insensitive when used in HTTP headers, and must be lowercase when used as query parameters in the URL. They are listed in the table in their canonical form.

@wunter8
Copy link
Contributor

wunter8 commented Mar 12, 2023

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server Relates to the main binary (server or client)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants