Document Matrix pushkey error + set log level to warnings for Matrix errors #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binwiederhier
requested changes
Aug 19, 2022
server/server_matrix.go
Outdated
| @@ -148,7 +148,7 @@ func writeMatrixDiscoveryResponse(w http.ResponseWriter) error { | |||
|
|
|||
| // writeMatrixError logs and writes the errMatrix to the given http.ResponseWriter as a matrixResponse | |||
| func writeMatrixError(w http.ResponseWriter, r *http.Request, v *visitor, err *errMatrix) error { | |||
| log.Debug("%s Matrix gateway error: %s", logHTTPPrefix(v, r), err.Error()) | |||
| log.Warn("%s Matrix gateway error: %s", logHTTPPrefix(v, r), err.Error()) | |||
There was a problem hiding this comment.
So as a rule I log most (all?) "bad request" type errors only as DEBUG, because otherwise users would be able to spam the logs, so I'd be strongly in favor of leaving this as DEBUG. I think we could make an "if >=500" here and log 500s as WARN, but that wouldn't catch errHTTPBadRequestMatrixPushkeyBaseURLMismatch.
There was a problem hiding this comment.
Sounds reasonnable.
christophehenry
force-pushed
the
document-pushkey-error
branch
from
4dbac43
to
ec64b41
Compare
|
Thanks |
|
@christophehenry Could you fix the test please: https://github.com/binwiederhier/ntfy/runs/7940253761?check_suite_focus=true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale is to clearly indicate what is set in the configuration compared to what was received in the request for debug purpose. Also, Matrix request errors now logs in warning level. I believe this can be disturbing having your setup not working and no error being logged in the default log level.