Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow empty password in client.yml #434

Merged
merged 3 commits into from
Oct 9, 2022

Conversation

wunter8
Copy link
Contributor

@wunter8 wunter8 commented Oct 9, 2022

fixes #374

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Base: 66.10% // Head: 66.08% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (dfec18b) compared to base (24940f8).
Patch coverage: 14.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   66.10%   66.08%   -0.02%     
==========================================
  Files          35       35              
  Lines        3720     3721       +1     
==========================================
  Hits         2459     2459              
- Misses        908      909       +1     
  Partials      353      353              
Impacted Files Coverage Δ
cmd/subscribe.go 29.87% <0.00%> (-0.20%) ⬇️
client/config.go 73.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binwiederhier
Copy link
Owner

Love it!

@binwiederhier binwiederhier merged commit 322abf4 into binwiederhier:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] User with empty password in client.yml does not work
3 participants