allow default-token and per-subscription tokens in client.yml #659
Conversation
| @@ -130,7 +133,7 @@ func TestCLI_Publish_Wait_PID_And_Cmd(t *testing.T) { | |||
| require.Equal(t, `command failed: does-not-exist-no-really "really though", error: exec: "does-not-exist-no-really": executable file not found in $PATH`, err.Error()) | |||
|
|
|||
| // Tests with NTFY_TOPIC set //// | |||
| require.Nil(t, os.Setenv("NTFY_TOPIC", topic)) | |||
There was a problem hiding this comment.
The tests after this one were failing because they kept connecting to the wrong ntfy server. It took me hours to figure out that this was the reason; the environment variable was persisting after this test and was affecting the remaining tests in the file.
There was a problem hiding this comment.
I didn't know you can do that t.Setenv. Wow. Sorry about that.
|
I realize it's a bit sloppy to include the latest commit here instead of in a second PR, but I needed it to pass the tests and eliminate the race condition in the old version of the tests here. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
==========================================
+ Coverage 67.15% 67.53% +0.38%
==========================================
Files 47 47
Lines 6631 6642 +11
==========================================
+ Hits 4453 4486 +33
+ Misses 1484 1465 -19
+ Partials 694 691 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -130,7 +133,7 @@ func TestCLI_Publish_Wait_PID_And_Cmd(t *testing.T) { | |||
| require.Equal(t, `command failed: does-not-exist-no-really "really though", error: exec: "does-not-exist-no-really": executable file not found in $PATH`, err.Error()) | |||
|
|
|||
| // Tests with NTFY_TOPIC set //// | |||
| require.Nil(t, os.Setenv("NTFY_TOPIC", topic)) | |||
There was a problem hiding this comment.
I didn't know you can do that t.Setenv. Wow. Sorry about that.
|
I just merged this 600 line PR without a single comment other than "wow i didn't know that". Those that know me know that that is pretty much an impossible thing to achieve. Great work and 100 thanks. |
|
I didn't even realize this was 600 lines, haha. I knew it was big, but I didn't expect it was that big |
fixes #653