Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA: Fix reload, Firefox mp3 load, reduce mobile padding #795

Merged
merged 5 commits into from Jun 30, 2023
Merged

PWA: Fix reload, Firefox mp3 load, reduce mobile padding #795

merged 5 commits into from Jun 30, 2023

Conversation

nimbleghost
Copy link
Contributor

No description provided.

@nimbleghost nimbleghost changed the title PWA: Fix Firefox mp3 load, reduce mobile padding PWA: Fix reload, Firefox mp3 load, reduce mobile padding Jun 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5784b07) 65.85% compared to head (0b91846) 65.85%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #795   +/-   ##
=======================================
  Coverage   65.85%   65.85%           
=======================================
  Files          53       53           
  Lines        7646     7646           
=======================================
  Hits         5035     5035           
  Misses       1775     1775           
  Partials      836      836           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binwiederhier
Copy link
Owner

The "hotfix" for the .mp3 stuff only required the .mp3 change, right? This PR includes a bunch of things. Hotfixes should only ever include the minimal possible change to make what's released already work.

Copy link
Owner

@binwiederhier binwiederhier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

Normally I'd do the changes myself and roll with it, but I'm too tired. Turns out real work is exhausting.

web/src/components/theme.js Show resolved Hide resolved
web/src/index.jsx Show resolved Hide resolved
web/vite.config.js Show resolved Hide resolved
@nimbleghost
Copy link
Contributor Author

nimbleghost commented Jun 30, 2023

Done!

Turns out real work is exhausting

especially the first weeks!

The "hotfix" for the .mp3 stuff only required the .mp3 change, right? This PR includes a bunch of things. Hotfixes should only ever include the minimal possible change to make what's released already work.

Indeed - I added the sw stuff because the sw was missing the client claim, and this will roll out the fixes faster than without

@binwiederhier binwiederhier merged commit 4f0ddfc into binwiederhier:main Jun 30, 2023
3 of 4 checks passed
@nimbleghost nimbleghost deleted the pwa-improvements branch June 30, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants