Web app: add RTL support #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binwiederhier
approved these changes
Jul 4, 2023
| useEffect(() => { | ||
| document.documentElement.setAttribute("lang", i18n.language); | ||
| document.dir = languageDir; | ||
| }, [i18n.language, languageDir]); |
There was a problem hiding this comment.
Dumb question:
- Should this not be
i18n.resolvedLanguageeverywhere? I had to do that in the preferences to avoid issues. - Have you tested this with a cleared localStorage, i.e. without a language?
There was a problem hiding this comment.
resolvedLanguageis specifically for preferences - it references a value in your supported languages, so you can match it to an option with the user.languageis fine for all other use cases: https://www.i18next.com/overview/api#language- works fine in incognito. it will use the fallback language if it can't detect one based on what the browser reports, or if it doesn't match a supported language.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #663
Resolves #700
MUI has pretty good RTL support, not much to do except connect mui & i18next.
I do not read an RTL language, so probably want someone else to double check that it looks correct, but going by my basic knowledge and the Material reference, it seems fine.
https://mui.com/material-ui/guides/right-to-left
https://m2.material.io/design/usability/bidirectionality.html