Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitIgnore filters eleventy output #61

Closed
asbjornb opened this issue Oct 13, 2021 · 0 comments · Fixed by #62
Closed

GitIgnore filters eleventy output #61

asbjornb opened this issue Oct 13, 2021 · 0 comments · Fixed by #62
Labels
bug Something isn't working

Comments

@asbjornb
Copy link
Contributor

Describe the bug
Currently everything in .gitignore is ignored when serving the site with npm start.

To Reproduce

  1. Clone the template
  2. Add notes/ to .gitignore
  3. run npm install from terminal
  4. run npm start from terminal

Expected behavior
I can't say for sure if .gitignore is meant to be respected by 11 in this project, but I think not due to the useGitIgnore: false.
If so though - I expect it to still serve the files in .gitignore as long as they are not in .eleventyignore

Environment (please complete the following information):

  • Windows 10 business
  • chrome

Additional info
Current implementation is not using the eleventyConfig.setUseGitIgnore(false); specification in the official docs at https://www.11ty.dev/docs/ignores/

@asbjornb asbjornb added the bug Something isn't working label Oct 13, 2021
binyamin added a commit that referenced this issue Oct 14, 2021
Fixes #61 outdated useGitIgnore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant