Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gene locations #149

Merged
merged 2 commits into from Sep 23, 2016
Merged

Gene locations #149

merged 2 commits into from Sep 23, 2016

Conversation

eparejatobes
Copy link
Member

@eparejatobes eparejatobes commented Sep 23, 2016

We have an enum for UniProt gene locations, but no property storing this data.

  • Where this should go
  • Add the corresponding property

@eparejatobes
Copy link
Member Author

The gene location corresponds to the gene, which do not actually exist in UniProt. The possible places where this property could go are

  1. entry protein vertices
  2. gene product edges

Gene (names) are not an option because of possible conflicts between equally named genes with different locations. I'm following 2. above as a lesser evil.

@eparejatobes
Copy link
Member Author

eparejatobes commented Sep 23, 2016

LGTM

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant